Some changes to clean up image loading code, and speed up subject image loading.

• lib-classifier: remove useEffect from useSubjectImage, so that image loading code runs on image load, rather than waiting for the next React render cycle.
• lib-react-components: when there's no delay for useProgressiveImage, run the onLoad handler immediately, rather than waiting for the next event cycle.
• refactor onLoad event handlers to use load events, rather than Image objects. This brings the event handlers in line with the DOM standard, and allows them to be attached directly to img elements.

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

• lib-classifier
• lib-react-components

Linked Issue and/or Talk Post

• a discussion on Talk about slow-loading subjects, compared to the same images in PFE/Talk.
• React: You might not need an Effect.

How to Review

Image behaviour shouldn't have changed much in this PR, but the removal of the effect hooks, and the JS timeout, means that image onLoad handlers should run immediately, rather than waiting for the next React render cycle, or for the main browser thread to be free. That's probably not a big deal on a fast machine, but should make a difference to subject loading performance on slower devices.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

• Tests are passing locally and on Github
• Documentation is up to date and changelog has been updated if appropriate
• You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
• FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
• FEM works in a mobile browser

General UX

Example Staging Project: i-fancy-cats

• All pages of a FEM project load: Home Page, Classify Page, and About Pages
• Can submit a classification
• Can sign-in and sign-out
• The component is accessible
  • Can be used with a screen reader BBC guide to VoiceOver
  • Can be used from the keyboard WebAIM guide to keyboard testing
  • It is passing accessibility checks in the storybook

Refactoring

• The PR creator has described the reason for refactoring
• The refactored component(s) continue to work as expected